[mercury] Remove elevation-1 default border and background
#682
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…laying slotted content
(Should only apply for "tab-list-outlined")
This cases have not been discused yet. Keeping them commented in case design decides to keep them.
These variants are hidden because they have not been discussed yet.
This helper border was included to show the component boundary, when it has not a visible border. This feature for the showcase was not approved.
Elevation classes should be applied on the tab itself
bsastregx
added
mercury
- The mentioned variants were not approved. The only tab style is the default, that has no background and no border
bsastregx
changed the title
[mercury] Remove border, default background, and add default background to tab-list[mercury] Remove elevation-1 default border and background
…ples - Remove 18 --tab-caption tokens - Apply CSS properties directly in mixins - Consolidate duplicate hover/active states - Remove ~41 lines of duplicate code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes in this PR:
Mercury
[tab]Removes the border and the defaultelevation-1background, and applies a defaultsurfacebackground to the tab-list. This changes reduce visual clutter and achieves a cleaner, simpler UI.Note
The default
surfacebackground to the tab-list prevents the tab parent container background color from showing below the tab-list, whensortableproperty istrue, and the user drags/reorder tab buttons.Bafore:
After:
